[Otel] Enable OTEL feature when OTEL image exists#22341
Merged
StormLiangMS merged 6 commits intosonic-net:masterfrom Mar 12, 2026
Merged
[Otel] Enable OTEL feature when OTEL image exists#22341StormLiangMS merged 6 commits intosonic-net:masterfrom
StormLiangMS merged 6 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Janet Cui <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Janetxxx
added
the
Request for 202511 branch
Signed-off-by: Janet Cui <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
approved these changes
Feb 12, 2026
Contributor
|
Please change the PR title |
r12f
requested changes
Feb 13, 2026
Collaborator
r12f
left a comment
r12f
left a comment
There was a problem hiding this comment.
Please update the PR title. 20241212.49 is not visible in community.
This should be checking if OTEL feature exist or not.
Collaborator
|
CI is also failing. need to fix. |
Janetxxx
changed the title
Signed-off-by: Janet Cui <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Janet Cui <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
reviewed
Mar 5, 2026
Signed-off-by: Janet Cui <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Janet Cui <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
PR checker container_hardening/test_container_hardening.py will be passed once sonic-net/sonic-buildimage#25930 gets merged |
Pterosaur
approved these changes
Mar 6, 2026
r12f
approved these changes
Mar 11, 2026
Janetxxx
added
Included in msft-202412 Branch
and removed
Cherry Pick Conflict_msft-202412
labels
vmittal-msft
added
Approved for 202511 branch
and removed
Approved for 202511 branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 16, 2026
What is the motivation for this PR? Enable OTEL feature when OTEL image exists How did you do it? Add a function to check if otel docker image exists, if yes, enable otel feature. How did you verify/test it? Verified it in internal setup. Any platform specific information? Nvidia SN5640 Supported testbed topology if it's a new test case? to-isolated-d32u32s2 Signed-off-by: Janet Cui <[email protected]> Signed-off-by: mssonicbld <[email protected]>
Collaborator
|
Cherry-pick PR to 202511: #23006 |
12 tasks
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Mar 16, 2026
What is the motivation for this PR? Enable OTEL feature when OTEL image exists How did you do it? Add a function to check if otel docker image exists, if yes, enable otel feature. How did you verify/test it? Verified it in internal setup. Any platform specific information? Nvidia SN5640 Supported testbed topology if it's a new test case? to-isolated-d32u32s2 Signed-off-by: Janet Cui <[email protected]> Signed-off-by: selldinesh <[email protected]>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
What is the motivation for this PR? Enable OTEL feature when OTEL image exists How did you do it? Add a function to check if otel docker image exists, if yes, enable otel feature. How did you verify/test it? Verified it in internal setup. Any platform specific information? Nvidia SN5640 Supported testbed topology if it's a new test case? to-isolated-d32u32s2 Signed-off-by: Janet Cui <[email protected]> Signed-off-by: Abhishek <[email protected]>
vmittal-msft
pushed a commit
that referenced
this pull request
Mar 19, 2026
What is the motivation for this PR? Enable OTEL feature when OTEL image exists How did you do it? Add a function to check if otel docker image exists, if yes, enable otel feature. How did you verify/test it? Verified it in internal setup. Any platform specific information? Nvidia SN5640 Supported testbed topology if it's a new test case? to-isolated-d32u32s2 Signed-off-by: Janet Cui <[email protected]> Signed-off-by: mssonicbld <[email protected]> Co-authored-by: Janet Cui <[email protected]>
mssonicbld
added
Included in 202511 branch
and removed
Created PR to 202511 branch
labels
vrajeshe
pushed a commit
to vrajeshe/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
What is the motivation for this PR? Enable OTEL feature when OTEL image exists How did you do it? Add a function to check if otel docker image exists, if yes, enable otel feature. How did you verify/test it? Verified it in internal setup. Any platform specific information? Nvidia SN5640 Supported testbed topology if it's a new test case? to-isolated-d32u32s2 Signed-off-by: Janet Cui <[email protected]> Signed-off-by: Venkata Gouri Rajesh Etla <[email protected]>
Pterosaur
pushed a commit
to Pterosaur/sonic-mgmt
that referenced
this pull request
Mar 25, 2026
What is the motivation for this PR? Enable OTEL feature when OTEL image exists How did you do it? Add a function to check if otel docker image exists, if yes, enable otel feature. How did you verify/test it? Verified it in internal setup. Any platform specific information? Nvidia SN5640 Supported testbed topology if it's a new test case? to-isolated-d32u32s2 Signed-off-by: Janet Cui <[email protected]>
Pterosaur
pushed a commit
to Pterosaur/sonic-mgmt
that referenced
this pull request
Mar 25, 2026
…ngleasic call PR sonic-net#1067 cherry-picked the otel feature enablement from upstream PR sonic-net#22341, but the upstream overwrite_feature_golden_config_db_singleasic() accepts optional auto_restart and state parameters, while the 202412 branch version only accepts (config, feature_key) and hardcodes both as 'enabled'. This causes a TypeError at runtime: TypeError: overwrite_feature_golden_config_db_singleasic() takes 3 positional arguments but 5 were given Fix by removing the extra arguments since the 202412 branch already hardcodes the desired 'enabled' values. Signed-off-by: Copilot <[email protected]> Signed-off-by: Dashuai Zhang <[email protected]>
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
What is the motivation for this PR? Enable OTEL feature when OTEL image exists How did you do it? Add a function to check if otel docker image exists, if yes, enable otel feature. How did you verify/test it? Verified it in internal setup. Any platform specific information? Nvidia SN5640 Supported testbed topology if it's a new test case? to-isolated-d32u32s2 Signed-off-by: Janet Cui <[email protected]>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Apr 1, 2026
What is the motivation for this PR? Enable OTEL feature when OTEL image exists How did you do it? Add a function to check if otel docker image exists, if yes, enable otel feature. How did you verify/test it? Verified it in internal setup. Any platform specific information? Nvidia SN5640 Supported testbed topology if it's a new test case? to-isolated-d32u32s2 Signed-off-by: Janet Cui <[email protected]> Signed-off-by: selldinesh <[email protected]>
albertovillarreal-keys
pushed a commit
to albertovillarreal-keys/sonic-mgmt
that referenced
this pull request
Apr 3, 2026
What is the motivation for this PR? Enable OTEL feature when OTEL image exists How did you do it? Add a function to check if otel docker image exists, if yes, enable otel feature. How did you verify/test it? Verified it in internal setup. Any platform specific information? Nvidia SN5640 Supported testbed topology if it's a new test case? to-isolated-d32u32s2 Signed-off-by: Janet Cui <[email protected]>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Apr 13, 2026
What is the motivation for this PR? Enable OTEL feature when OTEL image exists How did you do it? Add a function to check if otel docker image exists, if yes, enable otel feature. How did you verify/test it? Verified it in internal setup. Any platform specific information? Nvidia SN5640 Supported testbed topology if it's a new test case? to-isolated-d32u32s2 Signed-off-by: Janet Cui <[email protected]> Signed-off-by: opcoder0 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Enable OTEL feature when OTEL image exists
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Enable OTEL feature when OTEL image exists
How did you do it?
Add a function to check if otel docker image exists, if yes, enable otel feature.
How did you verify/test it?
Verified it in internal setup.
Any platform specific information?
Nvidia SN5640
Supported testbed topology if it's a new test case?
to-isolated-d32u32s2
Documentation